Switch to CPack for packaging #379
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkropachev
force-pushed
the
dk/switch-to-cpack-for-packaging
branch
6 times, most recently
from
d1d9612 to
552f8f1
Compare
Windows building fails with:
```
error[E0308]: mismatched types
--> src\cass_error.rs:137:81
|
137 | CassError((CassErrorSource::CASS_ERROR_SOURCE_SERVER.0 << 24) | (*num as u32))
| ^^^^^^^^^^^^^ expected `i32`, found `u32`
error[E0277]: no implementation for `i32 | u32`
--> src\cass_error.rs:137:79
|
137 | CassError((CassErrorSource::CASS_ERROR_SOURCE_SERVER.0 << 24) | (*num as u32))
| ^ no implementation for `i32 | u32`
```
dkropachev
force-pushed
the
dk/switch-to-cpack-for-packaging
branch
8 times, most recently
from
2802f9a to
81c2641
Compare
dkropachev
force-pushed
the
dk/switch-to-cpack-for-packaging
branch
from
81c2641 to
4c2a4dd
Compare
wprzytula
reviewed
Oct 7, 2025
| set(CPACK_PACKAGE_CONTACT "ScyllaDB <info@scylladb.com>") | ||
| set(CPACK_PACKAGE_DESCRIPTION_SUMMARY | ||
| "ScyllaDB C++ driver backed by the Rust core driver") | ||
| set(CPACK_PACKAGE_HOMEPAGE_URL "https://github.com/scylladb/cpp-rust-driver") |
There was a problem hiding this comment.
Suggested change
| set(CPACK_PACKAGE_HOMEPAGE_URL "https://github.com/scylladb/cpp-rust-driver") | |
| set(CPACK_PACKAGE_HOMEPAGE_URL "https://github.com/scylladb/cpp-rs-driver") |
| set(CPACK_GENERATOR "productbuild;DragNDrop") | ||
| set(CPACK_PACKAGE_FILE_NAME | ||
| "${_CPACK_PACKAGE_NAME}-${PROJECT_VERSION_STRING}-macos") | ||
| set(CPACK_PRODUCTBUILD_IDENTIFIER "com.scylladb.cpp-rust-driver") |
There was a problem hiding this comment.
❓ Sometimes you write cpp-driver and sometimes cpp-rust-driver. Is the discrepancy intended?
🔧 cpp-rust-driver -> cpp-rs-driver
Comment on lines
+38
to
+40
| 11. Build binary packages with CPack on each target platform (Linux, macOS, Windows). The README provides the exact command sequence (`cmake -S`, `cmake --build`, `cpack -G <generator>`). If you do not have access to the platforms locally, trigger a run of the reusable workflow `.github/workflows/build-cpack-packages.yml` from another workflow and download the resulting artifacts. | ||
| 12. Go to https://github.com/scylladb/cpp-rust-driver/releases , click the `Draft new release` button and follow the procedure to create a new release on GitHub. Use the release notes as its description. | ||
| 13. After the release is published, the `Attach Packages to Release` workflow (`.github/workflows/release-upload-packages.yml`) automatically builds fresh packages using CPack and uploads every artifact to the release. Verify that the workflow finished successfully and that RPM/DEB/MSI/PKG/DMG files are attached. |
There was a problem hiding this comment.
❓ What is the intended difference between building packages in point 11 and 13?
Comment on lines
+446
to
+447
| Debian packages set shlibdeps automatically; RPM packages target the | ||
| `Applications/Databases` group and use release number `1` by default. |
There was a problem hiding this comment.
❓ What does it mean? It's all Greek to me.
Comment on lines
+454
to
+455
| Both outputs bundle the compiled libraries alongside headers and pkg-config | ||
| manifests. |
There was a problem hiding this comment.
❓ This also uses naming that is unknown to me.
Comment on lines
+137
to
+141
| // On windows enums are i32, so we need to cast it | ||
| #[allow(clippy::unnecessary_cast)] | ||
| let source = CassErrorSource::CASS_ERROR_SOURCE_SERVER.0 as u32; | ||
| let code = (source << 24) | (*num as u32); | ||
| CassError(code as _) |
There was a problem hiding this comment.
Quite an unexpected catch.
Comment on lines
+4
to
+33
| workflow_call: | ||
| inputs: | ||
| build-type: | ||
| description: CMake build type used for packaging | ||
| type: string | ||
| default: Release | ||
| extra-cmake-flags: | ||
| description: Additional flags passed to CMake configure step | ||
| type: string | ||
| default: "" | ||
| save-artifacts: | ||
| description: Save built packages as artifacts | ||
| type: boolean | ||
| default: false | ||
| secrets: {} | ||
| workflow_dispatch: | ||
| inputs: | ||
| build-type: | ||
| description: CMake build type used for packaging | ||
| type: string | ||
| default: Release | ||
| extra-cmake-flags: | ||
| description: Additional flags passed to CMake configure step | ||
| type: string | ||
| default: "" | ||
| save-artifacts: | ||
| description: Save built packages as artifacts | ||
| type: boolean | ||
| default: false | ||
| secrets: {} |
There was a problem hiding this comment.
📝 It's a pity we need to be that WET instead of DRY. Chat GPT, however, hasn't come up with a better solution for enabling both manual dispatch and being called from another workflow, both with the same parameters and configuration.
Comment on lines
+3
to
+5
| SHELL = bash | ||
|
|
||
| SHELL = bash |
Comment on lines
+5
to
+7
| SHELL = bash | ||
| ifeq ($(OS),Windows_NT) | ||
| SHELL := pwsh.exe |
There was a problem hiding this comment.
🔧 I believe it's an error to mix eager binding := operator with late binding operator = for the same variable. Do you agree?
| sudo dpkg -i "${DRIVER_PACKAGES[@]}" | ||
| sudo apt-get install -f -y | ||
| - name: Build smoke-test application package |
There was a problem hiding this comment.
⛏️ Let's add a missing (DEB and RPM) suffix, so this step's name isconsistency with other steps ((DEB) only) is explicit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-review checklist
Makefilein{SCYLLA,CASSANDRA}_(NO_VALGRIND_)TEST_FILTER.Fixes:annotations to PR description.